fix(other): fix currency formatting throughout app (#228) #229
Conversation
…#228) Currencies in English should always have symbols and codes precede the amount, not follow them, so this commit fixes all such instances throughout the app.
|
I'm not sure this is a desirable change. One could argue that the unit should be locale aware but 5 btc definitely makes more sense in the US than btc 5. I think the right thing to do here would be to display the number and unit based on the user's locale. cc @bucko13 thoughts? |
It does not, as shown on this US GPO style guide. In fact, they're based on languages, and in English (regardless of locale/dialect), codes and symbols always precede the amount (e.g., |
|
Yikes. Old. Sorry. I think we should probably establish a formatting guideline around a lot of things like this, regardless of where we end up and it should be made public in a document in the repo for any contributors. Absent that and since I could see an argument either way, I say we close for now until then. |
|
@bucko13 That's fine, but the formatting document would just publicize the format that this PR is fixing anyway, since that's the proper way to format currencies in English, so why not just merge instead? |
Currencies in English should always have symbols and codes precede the
amount, not follow them, so this commit fixes all such instances
throughout the app.
Description
The change fixes grammatical issues in the app.
Fixes #228
Does this PR introduce a breaking change?
Does this PR fix an open issue?